neilcsmith-net commented on PR #8276: URL: https://github.com/apache/netbeans/pull/8276#issuecomment-2693813239
@mbien no problem, however I still don't particularly like your current implementation - I preferred your original ... > The second point was that due to the nature of having to decouple from the thread (EDT or not) in the enable() method due to the delay, the first method already is thread safe by nature. Is it? The implementation might be thread safe, but I'm not aware that Timer methods are documented to be thread safe? I suggested Timer because it's good for situations where all control and callbacks are intended to happen on the EDT. I prefer trying to keep concurrent code isolated and together, rather than sprinkled around - ie. part of the call to the `ViewUtil.uiProcessor`. And any delayed UI code should not, itself, have to be thread-safe. This is a lot of discussion for a minor change! :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
