jtulach commented on code in PR #8756:
URL: https://github.com/apache/netbeans/pull/8756#discussion_r2295516145
##########
ide/dlight.terminal/src/org/netbeans/modules/dlight/terminal/action/TerminalSupportImpl.java:
##########
@@ -267,14 +268,14 @@ private void doWork() {
term.setEmulation("xterm"); // NOI18N
NativeProcessBuilder npb =
NativeProcessBuilder.newProcessBuilder(env);
+ final MacroMap envVars = npb.getEnvironment();
// clear env modified by NB. Let it be initialized by
started shell process
- npb.getEnvironment().put("LD_LIBRARY_PATH", "");//
NOI18N
- npb.getEnvironment().put("DYLD_LIBRARY_PATH", "");//
NOI18N
-
+ envVars.put("LD_LIBRARY_PATH", "");// NOI18N
+ envVars.put("DYLD_LIBRARY_PATH", "");// NOI18N
Review Comment:
- it was always clear to me I need to set an _environment variable_ to
represent the value of `--userdir`
- otherwise the `CLIHandler` won't be able to connect to the same NetBeans
process
- originally I thought I will have to make changes here, but ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
