neilcsmith-net commented on code in PR #8756:
URL: https://github.com/apache/netbeans/pull/8756#discussion_r2295581421
##########
nb/ide.launcher/unix/netbeans:
##########
@@ -38,6 +38,9 @@ cd "$progdir"/..
basedir=`pwd`
cd "$old"
+# make sure own launcher is on PATH
+PATH=$PATH:$progdir
Review Comment:
Why append and not prepend? If anyone has `netbeans` in the `PATH`, which
will include anyone who has installed DEB or RPM versions, and is running an
alternative version then this will launch the default instead?
##########
nb/ide.launcher/unix/netbeans:
##########
@@ -66,7 +69,11 @@ fi
export DEFAULT_USERDIR_ROOT
# #68373: look for userdir, but do not modify "$@"
-userdir="${netbeans_default_userdir}"
+if [ -z "$NETBEANS_USERDIR" ]; then
Review Comment:
I'm not sure what that has to do with `jdkhome` ? We should take `jdkhome`
into account, which might be better handled by ensuring `JAVA_HOME` is set
inside the launcher. This is the parallel of #8725 It would be another reason
for ensuring that value is set to `jdkhome` inside the IDE.
The DEB and RPM launchers already do this - very useful to pick up the JDK
the IDE is running on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
