jtulach commented on code in PR #8756:
URL: https://github.com/apache/netbeans/pull/8756#discussion_r2295993355


##########
nb/ide.launcher/unix/netbeans:
##########
@@ -38,6 +38,9 @@ cd "$progdir"/..
 basedir=`pwd`
 cd "$old"
 
+# make sure own launcher is on PATH
+PATH=$PATH:$progdir

Review Comment:
   > Why append and not prepend?
   
   I wanted to _play it safe_, but you are right. Inside of NetBeans terminal, 
it is safer to have the same `netbeans` executable invoked by default. Fixed in 
914565a5be
   
   > typing $NB pom.xml
   
   Typing `netbeans` feels long, right? I also have a `nb` symlink and I will 
update it to point to the right `netbeans` executable or change it to `alias 
nb=netbeans`.
   
   I leave this "shortcutting" out of scope of this PR. The important change is 
the support for _"inheriting user dir"_. Everything else is easy to script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to