jtulach commented on code in PR #8756:
URL: https://github.com/apache/netbeans/pull/8756#discussion_r2296002276
##########
nb/ide.launcher/unix/netbeans:
##########
@@ -66,7 +69,11 @@ fi
export DEFAULT_USERDIR_ROOT
# #68373: look for userdir, but do not modify "$@"
-userdir="${netbeans_default_userdir}"
+if [ -z "$NETBEANS_USERDIR" ]; then
Review Comment:
> take `jdkhome` into account, which might be better handled by ensuring
`JAVA_HOME` is set inside the launcher.
- I left a comment at
https://github.com/apache/netbeans/pull/8725/files#r2295966792
- great to hear about #8725
- I leave `JAVA_HOME` outside of the scope of this PR and
- I let the #8725 deal with the `JAVA_HOME` handling on is own
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
