jtulach commented on code in PR #8756: URL: https://github.com/apache/netbeans/pull/8756#discussion_r2311885704
########## nb/ide.launcher/unix/netbeans: ########## @@ -38,6 +38,9 @@ cd "$progdir"/.. basedir=`pwd` cd "$old" +# make sure own launcher is on PATH +PATH=$PATH:$progdir Review Comment: I don't want to do _"unusual things"_ in this PR, thus: - either I revert back to append - it works for me and causes no surprises - or I don't modify PATH at all - hoping `netbeans` is already on PATH > The move to prepend rather than append fixes one problem - this "[problem](https://github.com/apache/netbeans/pull/8756#discussion_r2295581421)"? - it is not a problem as far as I can tell - something gets invoked, something happens - once the DEB or RPM launcher honors here in introduced `NETBEANS_USERDIR` environment variable... - then the behavior will even be exactly as expected - thus I'd say appending is the best way to modify `PATH` (should this PR modify `PATH` at all) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
