neilcsmith-net commented on code in PR #8756: URL: https://github.com/apache/netbeans/pull/8756#discussion_r2311846041
########## nb/ide.launcher/unix/netbeans: ########## @@ -38,6 +38,9 @@ cd "$progdir"/.. basedir=`pwd` cd "$old" +# make sure own launcher is on PATH +PATH=$PATH:$progdir Review Comment: Sure, it's unusual, but we need some way that a wrapper script can override this, and that is not path order dependent. Setting the PATH feels a little unsafe and unnecessary, and is going to break in interesting ways away from the zip bundle. The move to prepend rather than append fixes one problem but would introduce another, by bypassing the wrapper script for a system install. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
