giftig commented on PR #25961: URL: https://github.com/apache/superset/pull/25961#issuecomment-1833405455
@villebro in my case I sometimes look for virtual datasets I've created by searching by creator. I don't think it's necessary for the list view (in fact I've only just noticed it's missing from there since "modified by" was generally the creator). I think it'd be good to keep the ability to search by it. We encourage our users to always create virtual datasets when building charts, as we want them to use a macro we've written which enforces a date filter and prevents accidentally querying too much data. That means we have a lot of virtual datasets (added to thousands of physical ones). Searching by owner would usually work, but users working with their teams might be assigning ownership to other people and it might get muddied. I'm somewhat speculating here as we don't have enough usage information from our users. Searching by modified would probably be misleading if someone else has since touched your dataset. So I think I'd lean towards continuing to allow searching by original creator, but agree that it's best to consistently exclude it from list views. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
