michael-s-molina commented on PR #25961: URL: https://github.com/apache/superset/pull/25961#issuecomment-1833873443
Thanks for working to improve consistency @villebro. Some things I noticed: - The filter is called `Owner` but the list header is `Owners` (plural). - Some filters use plural form and others use singular form in a inconsistent manner. I believe the nomenclature here should reflect the filter type. Singular for filters that allow only one value and plural for filters that allow multiple values. - `Last modified` generally has the form of `15 hours ago` but in the charts list it's `2023-11-30T13:53:56.840190` - The filter is called `Chart Type` in the charts list but in the datasets list it's called `Type` - The filter in the tags list is called `Search` instead of `Name` - In the database list the column is called `Name` but in the modal it's called `Display name` > I find that it's often of very limited utility to know who created a chart/dashboard - usually you really want to know who owns it, or who modified it last (the creator can often have left the team/org, hence may no longer be relevant, especially for long lived assets). I agree with this assessment but I'm wondering if this would constitute a breaking change according to our [Semantic Versioning](https://github.com/apache/superset/wiki/Semantic-Versioning) definition: > What is a breaking change? > > Changes that removes an existing functionality, such as a chart type or ability to select favorites. My suggestion would be to add a card to the [4.0 board](https://github.com/orgs/apache/projects/292) to remove the creator in the next major and for this PR, I would change the creator to be an avatar similar to the owners for consistency and to preserve real estate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
