kgabryje commented on code in PR #25961:
URL: https://github.com/apache/superset/pull/25961#discussion_r1410862910
##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -438,44 +434,30 @@ function ChartList(props: ChartListProps) {
{
Cell: ({
row: {
- original: { last_saved_by: lastSavedBy },
+ original: { owners = [] },
},
- }: any) => <>{changedByName(lastSavedBy)}</>,
- Header: t('Modified by'),
- accessor: 'last_saved_by.first_name',
+ }: any) => <FacePile users={owners} />,
+ Header: t('Owners'),
+ accessor: 'owners',
+ disableSortBy: true,
size: 'xl',
},
{
Cell: ({
row: {
- original: { last_saved_at: lastSavedAt },
+ original: { last_saved_at: changedOn, last_saved_by: changedBy },
},
}: any) => (
- <span className="no-wrap">
- {lastSavedAt ? moment.utc(lastSavedAt).fromNow() : null}
- </span>
+ <AuditInfo
+ type={AuditInfoType.Modified}
+ date={changedOn}
Review Comment:
Shouldn't we use `changed_on_delta_humanized` here? I'm seeing an
inconsistency between ChartList and for example DashboardList
<img width="1695" alt="image"
src="https://github.com/apache/superset/assets/15073128/25d8eb9d-a96b-4a40-b0c8-8205a9f8d9dc";>
<img width="1728" alt="image"
src="https://github.com/apache/superset/assets/15073128/eed473f7-99c4-4b9d-a985-64459c122d9a";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
