villebro commented on PR #25961: URL: https://github.com/apache/superset/pull/25961#issuecomment-1835072449
> * The filter is called `Owner` but the list header is `Owners` (plural). > * Some filters use plural form and others use singular form in a inconsistent manner. I believe the nomenclature here should reflect the filter type. Singular for filters that allow only one value and plural for filters that allow multiple values. I've updated these so that the single select filters are now singular (Tag, Owner). > * `Last modified` generally has the form of `15 hours ago` but in the charts list it's `2023-11-30T13:53:56.840190` Good catch - fixed. > * The filter is called `Chart Type` in the charts list but in the datasets list it's called `Type` Renamed to "Type" throughout. > * The filter in the tags list is called `Search` instead of `Name` Renamed to "Name". > * In the database list the column is called `Name` but in the modal it's called `Display name` Renamed "Display name" to "Name" in the modal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
