mistercrunch commented on code in PR #33230:
URL: https://github.com/apache/superset/pull/33230#discussion_r2208277303
##########
superset/connectors/sqla/models.py:
##########
@@ -523,6 +523,13 @@ def filter_values_handler( # pylint:
disable=too-many-arguments # noqa: C901
def handle_single_value(value: FilterValue | None) -> FilterValue |
None:
if operator == utils.FilterOperator.TEMPORAL_RANGE:
return value
+
+ if (
+ isinstance(value, (float, int))
+ and target_generic_type == utils.GenericDataType.NUMERIC
+ ):
+ value = float(value)
Review Comment:
why do we need to explicitly convert a float to a float here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
