betodealmeida commented on PR #33230: URL: https://github.com/apache/superset/pull/33230#issuecomment-3074974691
We most likely **do not** want to convert integers to floats, especially if they're being used in a comparison. Big integers are often used as IDs, and if they're are converted to floats they lose precision and become a different ID: ```python >>> i = 2**53 + 1 >>> i 9007199254740993 >>> float(i) 9007199254740992.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
