mistercrunch commented on code in PR #33230:
URL: https://github.com/apache/superset/pull/33230#discussion_r2208282119
##########
superset/connectors/sqla/models.py:
##########
@@ -548,6 +555,10 @@ def handle_single_value(value: FilterValue | None) ->
FilterValue | None:
):
# For backwards compatibility and edge cases
# where a column data type might have changed
+ try:
+ value = float(value)
Review Comment:
wait there's a method right below (`cast_to_num`) that's attempting to do
the same thing. I haven't looked into exactly what it does, but this feels like
a patch-on-a-patch and we really need to move away from this type of layering
here. My intuition says "let's get `cast_to_num` right and rely on it"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
