mistercrunch commented on code in PR #33230:
URL: https://github.com/apache/superset/pull/33230#discussion_r2208286902
##########
superset/models/helpers.py:
##########
@@ -1162,6 +1162,12 @@ def filter_values_handler( # pylint:
disable=too-many-arguments # noqa: C901
def handle_single_value(value: Optional[FilterValue]) ->
Optional[FilterValue]:
if operator == utils.FilterOperator.TEMPORAL_RANGE:
return value
+
+ if (
Review Comment:
there's long-standing issue where someone copied a bunch of methods/logic
between the two files in this PR, and we really need to fix this ...
@betodealmeida and myself have spoken about this and we're meaning to fix this
once and for all. Not sure what exactly it means for this PR, but I'd say if
we're going to fix a thing here let's dedup at least the method we're touching
here (`handle_single_value`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
