gabotorresruiz opened a new pull request, #35220: URL: https://github.com/apache/superset/pull/35220
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Implements a comprehensive base theme system for Apache Superset that ensures consistent theming across the application while maintaining flexibility for customization. This change introduces foundation themes (`BASE_THEME_DEFAULT` and `BASE_THEME_DARK`) that serve as the base layer for all theme configurations. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. **Test base theme only (default behavior)**: - Set `THEME_DEFAULT = None` and `THEME_DARK = None` in `config.py` - Start Superset and verify base themes are applied - Toggle between light/dark/system modes - Verify mode persists after page reload 2. **Test with base + config themes**: - Set custom `BASE_THEME_DEFAULT` and `BASE_THEME_DARK` in config.py: ```python BASE_THEME_DEFAULT = { "token": { "colorPrimary": "#1890ff", "borderRadius": 4 } } BASE_THEME_DARK = { "algorithm": "dark", "token": { "colorPrimary": "#177ddc" } } ``` - Add config overlays with `THEME_DEFAULT` and `THEME_DARK` - Verify base tokens persist unless explicitly overridden 3. **Test CRUD theme system**: - Create a custom theme via Theme CRUD UI - Test "Set as system default/dark theme" button - Verify theme applies with base theme foundation - Test "Remove as system theme" - should fallback to config/base - Verify only explicitly set system themes are used (no automatic fallback) 4. **Test dashboard CRUD themes**: - Apply a theme locally to a dashboard using the bolt button - Verify dashboard theme overlays on base theme - Confirm theme only applies to that dashboard context 5. **Test theme priority/overlay behavior**: Base Theme (always present) ↑ overlays Config Theme (THEME_DEFAULT/THEME_DARK) ↑ overlays System CRUD Theme (from DB) ↑ overlays Dashboard CRUD Theme (local with bolt) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
