mistercrunch commented on code in PR #35220:
URL: https://github.com/apache/superset/pull/35220#discussion_r2366479096
##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -148,6 +148,8 @@ export interface MenuData {
export interface BootstrapThemeDataConfig {
default: SerializableThemeConfig | {};
dark: SerializableThemeConfig | {};
+ baseThemeDefault?: SerializableThemeConfig | null;
Review Comment:
What if we just treated themes in CRUD as overrides on top of
THEME_DEFAULT/THEME_DARK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
