gabotorresruiz commented on code in PR #35220:
URL: https://github.com/apache/superset/pull/35220#discussion_r2366490675
##########
superset-frontend/src/types/bootstrapTypes.ts:
##########
@@ -148,6 +148,8 @@ export interface MenuData {
export interface BootstrapThemeDataConfig {
default: SerializableThemeConfig | {};
dark: SerializableThemeConfig | {};
+ baseThemeDefault?: SerializableThemeConfig | null;
Review Comment:
That's a great point! You're absolutely right that sending 4 theme configs
on every page load is getting excessive. I think your suggestion to treat
`THEME_DEFAULT/THEME_DARK` as the base themes makes a lot of sense.
Here's what I'm thinking:
**Current architecture:**
- **BASE_THEME_DEFAULT/BASE_THEME_DARK:** organization-wide base tokens
- **THEME_DEFAULT/THEME_DARK:** system themes (merged with base)
- **User CRUD themes:** also merged with base
**Simplified architecture:**
- **THEME_DEFAULT/THEME_DARK:** act as both system defaults and base themes
- **User CRUD themes:** simple overrides on top of the system themes
Let me know your thoughts on this @mistercrunch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
