mistercrunch commented on code in PR #35220: URL: https://github.com/apache/superset/pull/35220#discussion_r2366481487
########## superset-frontend/packages/superset-ui-core/src/theme/GlobalStyles.tsx: ########## @@ -16,6 +16,18 @@ * specific language governing permissions and limitations * under the License. */ + +// @fontsource/* v5.1+ doesn't play nice with eslint-import plugin v2.31+ +/* eslint-disable import/extensions */ +import '@fontsource/inter/200.css'; Review Comment: These fonts got carried over from the previous implementation, and they do look nice, but I'm wondering whether they're kind of just bloating the build in some ways. I'm wondering if we could either: - drop them to and use stock fonts in default build - dogfood the custom font system in default configs Probably beyond the scope of this PR, but wanted to bring it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
