Re: [PR] feat(mcp): add configurable branding for MCP service [superset]

Thu, 06 Nov 2025 12:05:51 -0800 


korbit-ai[bot] commented on code in PR #36033:
URL: https://github.com/apache/superset/pull/36033#discussion_r2500647589


##########
superset/mcp_service/mcp_config.py:
##########
@@ -60,10 +60,15 @@
     "WTF_CSRF_TIME_LIMIT": None,
 }
 
+# Branding Configuration
+# These values can be overridden in superset_config.py to customize branding
+MCP_SERVICE_NAME = "Superset MCP Server"  # Display name shown to AI clients
+MCP_SERVICE_BRANDING = "Apache Superset"  # Product name used in documentation

Review Comment:
   ### Unused branding configuration constant <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The MCP_SERVICE_BRANDING constant is defined but never used anywhere in the 
code, making it a dead configuration value.
   
   
   ###### Why this matters
   This creates confusion for developers who might expect this branding 
configuration to actually affect the service behavior or documentation, when it 
currently has no functional impact.
   
   ###### Suggested change ∙ *Feature Preview*
   Either remove the unused `MCP_SERVICE_BRANDING` constant or implement its 
usage in the appropriate places where branding should be applied:
   
   ```python
   # Remove if not needed:
   # MCP_SERVICE_BRANDING = "Apache Superset"
   
   # OR implement usage in factory config or other relevant places
   MCP_FACTORY_CONFIG = {
       "name": MCP_SERVICE_NAME,
       "branding": MCP_SERVICE_BRANDING,  # If supported by FastMCP
       # ... rest of config
   }
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/0ffc51f7-1ea3-4825-85bc-7f4de93d137f/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/0ffc51f7-1ea3-4825-85bc-7f4de93d137f?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/0ffc51f7-1ea3-4825-85bc-7f4de93d137f?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/0ffc51f7-1ea3-4825-85bc-7f4de93d137f?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/0ffc51f7-1ea3-4825-85bc-7f4de93d137f)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:1e7ebeac-ff24-4970-a6cc-1ff0878573e3 -->
   
   
   [](1e7ebeac-ff24-4970-a6cc-1ff0878573e3)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to