dpgaspar commented on code in PR #36033:
URL: https://github.com/apache/superset/pull/36033#discussion_r2517814544
##########
superset/mcp_service/mcp_config.py:
##########
@@ -62,8 +62,9 @@
# FastMCP Factory Configuration
MCP_FACTORY_CONFIG = {
- "name": "Superset MCP Server",
- "instructions": None, # Will use default from app.py
+ "name": None, # Will derive from APP_NAME in app.py
+ "branding": None, # Will derive from APP_NAME in app.py
+ "instructions": None, # Will use default from app.py (parameterized with
branding)
Review Comment:
We could add a test with a branded `APP_NAME` asserting that instructions
reflect this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
