aminghadersohi commented on PR #36033:
URL: https://github.com/apache/superset/pull/36033#issuecomment-3541187738
## ✅ Added Tests for APP_NAME Branding
As requested by @dpgaspar, I've added comprehensive tests to verify that the
MCP service branding configuration works correctly with custom `APP_NAME`
values.
### Tests Added (`tests/unit_tests/mcp_service/test_mcp_config.py`)
**1. Unit tests for `get_default_instructions()`:**
- ✅ Default branding produces "Apache Superset"
- ✅ Custom branding (e.g., "ACME Analytics") replaces default
- ✅ Enterprise branding includes all tool documentation
**2. Integration tests for `init_fastmcp_server()`:**
- ✅ Default `APP_NAME="Superset"` produces "Superset" branding
- ✅ Custom `APP_NAME="ACME Analytics"` produces custom branding in
instructions
- ✅ Server name is correctly derived as `"{APP_NAME} MCP Server"`
### Test Results
```
============================== test session starts
==============================
tests/unit_tests/mcp_service/test_mcp_config.py::test_get_default_instructions_with_default_branding
PASSED
tests/unit_tests/mcp_service/test_mcp_config.py::test_get_default_instructions_with_custom_branding
PASSED
tests/unit_tests/mcp_service/test_mcp_config.py::test_get_default_instructions_with_enterprise_branding
PASSED
tests/unit_tests/mcp_service/test_mcp_config.py::test_init_fastmcp_server_with_default_app_name
PASSED
tests/unit_tests/mcp_service/test_mcp_config.py::test_init_fastmcp_server_with_custom_app_name
PASSED
tests/unit_tests/mcp_service/test_mcp_config.py::test_init_fastmcp_server_derives_server_name_from_app_name
PASSED
============================== 6 passed in 1.00s
==============================
```
All tests pass and verify that the branding functionality works as expected!
✨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
