aminghadersohi commented on PR #36033:
URL: https://github.com/apache/superset/pull/36033#issuecomment-3505571975
Great point @rusackas! You're absolutely right - we should leverage
Superset's existing config instead of creating duplicate MCP-specific settings.
## Proposed Change
Instead of introducing `MCP_SERVICE_NAME` and `MCP_SERVICE_BRANDING`, we
should derive from existing Superset config:
**Current Superset Config:**
- `APP_NAME` (default: "Superset")
**What We'll Do:**
- MCP service name: `f"{APP_NAME} MCP Server"`
- MCP branding in instructions: `APP_NAME`
**Example:**
```python
# superset_config.py
APP_NAME = "ACME Analytics"
# Results in:
# - Server name: "ACME Analytics MCP Server"
# - Instructions: "You are connected to the ACME Analytics MCP service..."
```
This is more DRY, removes duplicate config, and ensures branding consistency
across the entire Superset deployment (UI, API, MCP service, etc.).
I'll update the PR to remove the MCP-specific config constants and derive
everything from `APP_NAME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
