Copilot commented on code in PR #40124:
URL: https://github.com/apache/superset/pull/40124#discussion_r3244941096
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -467,7 +467,15 @@ class AddChartToDashboardRequest(BaseModel):
)
chart_id: int = Field(..., description="ID of the chart to add to the
dashboard")
target_tab: str | None = Field(
- None, description="Target tab name (if dashboard has tabs)"
+ None,
+ description=(
+ "Tab to place the chart in. Accepts a tab display name "
+ "(e.g. 'Sales') or a tab component ID (e.g. 'TAB-abc123'). "
+ "Matching is case-insensitive and ignores leading/trailing emoji. "
Review Comment:
The `target_tab` description says matching "ignores leading/trailing emoji",
but `_normalize_tab_text()` strips emoji anywhere in the string (and also trims
whitespace + lowercases). Please update the schema description to match the
actual matching behavior so API/tool consumers aren’t misled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
