codeant-ai-for-open-source[bot] commented on code in PR #40124:
URL: https://github.com/apache/superset/pull/40124#discussion_r3245025334
##########
superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py:
##########
@@ -316,6 +333,46 @@ def _ensure_layout_structure(
layout["DASHBOARD_VERSION_KEY"] = "v2"
+def _resolve_parent_container(
+ layout: Dict[str, Any],
+ dashboard_id: int,
+ target_tab: str | None,
+) -> tuple[str, None] | tuple[None, AddChartToDashboardResponse]:
+ """Return (parent_id, None) on success or (None, error_response) on
mismatch.
+
+ When *target_tab* is specified and not found the caller receives a
+ descriptive error listing available tabs rather than a silent fallback.
+ """
+ tab_target = _find_tab_insert_target(layout, target_tab=target_tab)
+
+ if target_tab is not None and tab_target is None:
+ available = _collect_available_tab_names(layout)
+ if available:
+ tab_list = ", ".join(f"'{t}'" for t in available)
+ return None, AddChartToDashboardResponse(
+ dashboard=None,
+ dashboard_url=None,
+ position=None,
+ error=(
+ f"Tab '{target_tab}' not found in dashboard
{dashboard_id}. "
+ f"Available tabs: {tab_list}. "
+ "Use get_dashboard_info to inspect the tab structure."
+ ),
Review Comment:
**🟠Architect Review — HIGH**
The new guidance "Use get_dashboard_info to inspect the tab structure" is
incorrect: the get_dashboard_info tool (DashboardInfo schema) deliberately
omits layout/position_json and does not expose tab IDs or tab hierarchy, so
callers cannot inspect the tab structure or reliably discover tab IDs as
suggested.
**Suggestion:** Either extend get_dashboard_info/DashboardInfo to expose tab
layout metadata (at least tab display names and component IDs), or update both
the error message and AddChartToDashboardRequest.target_tab description so they
no longer promise tab discovery via get_dashboard_info and instead make the
error response self-contained.
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fmcp_service%2Fdashboard%2Ftool%2Fadd_chart_to_existing_dashboard.py%0A%2A%2ALine%3A%2A%2A%20357%3A360%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20The%20new%20guidance%20%22Use%20get_dashboard_info%20to%20inspect%20the%20tab%20structure%22%20is%20incorrect%3A%20the%20get_dashboard_info%20tool%20%28DashboardInfo%20schema%29%20deliberately%20omits%20layout%2Fposition_json%20and%20does%20not%20expose%20tab%20IDs
%20or%20tab%20hierarchy%2C%20so%20callers%20cannot%20inspect%20the%20tab%20structure%20or%20reliably%20discover%20tab%20IDs%20as%20suggested.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand%20scope%20beyond%20the%20finding.%0AOnce%20fi
x%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fmcp_service%2Fdashboard%2Ftool%2Fadd_chart_to_existing_dashboard.py%0A%2A%2A
Line%3A%2A%2A%20357%3A360%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20The%20new%20guidance%20%22Use%20get_dashboard_info%20to%20inspect%20the%20tab%20structure%22%20is%20incorrect%3A%20the%20get_dashboard_info%20tool%20%28DashboardInfo%20schema%29%20deliberately%20omits%20layout%2Fposition_json%20and%20does%20not%20expose%20tab%20IDs%20or%20tab%20hierarchy%2C%20so%20callers%20cannot%20inspect%20the%20tab%20structure%20or%20reliably%20discover%20tab%20IDs%20as%20suggested.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20sugg
estion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review.
These reviews are first-class, important findings — not optional suggestions.
Do NOT dismiss this as a 'big architectural change' just because the title says
architect review; most of these can be resolved with a small, localized fix
once the intent is understood.
**Path:**
superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py
**Line:** 357:360
**Comment:**
*HIGH: The new guidance "Use get_dashboard_info to inspect the tab
structure" is incorrect: the get_dashboard_info tool (DashboardInfo schema)
deliberately omits layout/position_json and does not expose tab IDs or tab
hierarchy, so callers cannot inspect the tab structure or reliably discover tab
IDs as suggested.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative
instruction. If no explicit code suggestion is given, you MUST still draft and
apply your own minimal, localized fix — do not punt back with 'no suggestion
provided, review manually'. Keep the change as small as possible: add a guard
clause, gate on a loading state, reorder an await, wrap in a conditional, etc.
Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
