bito-code-review[bot] commented on code in PR #41129:
URL: https://github.com/apache/superset/pull/41129#discussion_r3485773682
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -134,6 +134,7 @@ const RightMenu = ({
EXCEL_EXTENSIONS,
ALLOWED_EXTENSIONS,
HAS_GSHEETS_INSTALLED,
+ SCARF_ANALYTICS,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>CWE-N: Missing test for opt-out logic</b></div>
<div id="fix">
Rule [6262] requires tests to verify actual business logic. The new
`enabled` prop controlling the telemetry pixel opt-out has no test coverage in
`RightMenu.test.tsx`. Add tests that assert the TelemetryPixel receives the
correct `enabled` prop based on `SCARF_ANALYTICS` config values (undefined,
true, false).
</div>
</div>
<small><i>Code Review Run #b169ce</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
