bito-code-review[bot] commented on code in PR #41129:
URL: https://github.com/apache/superset/pull/41129#discussion_r3486375768
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -781,6 +782,7 @@ const RightMenu = ({
// segments in the Scarf pixel URL.
sha={navbarRight.version_sha || undefined}
build={navbarRight.build_number || undefined}
+ enabled={SCARF_ANALYTICS !== false}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test for telemetry opt-out</b></div>
<div id="fix">
Add tests in `RightMenu.test.tsx` to assert that `TelemetryPixel` is not
rendered when `SCARF_ANALYTICS` is `false`, and is rendered when `true` or
`undefined`, ensuring coverage of the new opt-out logic.
</div>
</div>
<small><i>Code Review Run #8be15c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
