rusackas commented on code in PR #41129:
URL: https://github.com/apache/superset/pull/41129#discussion_r3485852083
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -134,6 +134,7 @@ const RightMenu = ({
EXCEL_EXTENSIONS,
ALLOWED_EXTENSIONS,
HAS_GSHEETS_INSTALLED,
+ SCARF_ANALYTICS,
Review Comment:
The opt-out logic itself is covered in `TelemetryPixel.test.tsx`
(renders/doesn't render based on `enabled`), and the config exposure in
`test_base.py`. `RightMenu` just forwards `SCARF_ANALYTICS !== false`, so a
test there would only re-assert a one-line pass-through. Leaving as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
