bito-code-review[bot] commented on code in PR #41129:
URL: https://github.com/apache/superset/pull/41129#discussion_r3485852392
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -134,6 +134,7 @@ const RightMenu = ({
EXCEL_EXTENSIONS,
ALLOWED_EXTENSIONS,
HAS_GSHEETS_INSTALLED,
+ SCARF_ANALYTICS,
Review Comment:
<!-- Bito Reply -->
The user's explanation regarding the existing test coverage for the opt-out
logic in `TelemetryPixel.test.tsx` and `test_base.py` is reasonable. Since
`RightMenu` only performs a simple pass-through of the `SCARF_ANALYTICS`
configuration, adding a test in `RightMenu.test.tsx` would indeed be redundant
and provide little additional value. The current approach of verifying the
logic in the component that consumes the prop and the configuration exposure in
the base tests is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
