codeant-ai-for-open-source[bot] commented on code in PR #42495: URL: https://github.com/apache/superset/pull/42495#discussion_r3694185750
########## docker/pythonpath_dev/superset_config.py: ########## @@ -114,7 +114,13 @@ class CeleryConfig: } EXTENSIONS_PATH = "/app/docker/extensions" ALERT_REPORTS_NOTIFICATION_DRY_RUN = True -WEBDRIVER_BASEURL = f"http://superset_app{os.environ.get('SUPERSET_APP_ROOT', '/')}/" # When using docker compose baseurl should be http://superset_nginx{ENV{BASEPATH}}/ # noqa: E501 +# The Docker Compose app service is named "superset" and listens on 8088. Report +# paths are root-relative, so urljoin drops the base path; only the scheme, host, +# and port must be correct here. SUPERSET_APP_ROOT is kept for consumers that +# concatenate paths directly (e.g. cache warm-up). For screenshots in the dev +# stack (unbuilt static assets) point this at the nginx service instead: +# http://nginx{SUPERSET_APP_ROOT}/ +WEBDRIVER_BASEURL = f"http://superset:8088{os.environ.get('SUPERSET_APP_ROOT', '/')}/" Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Keep the default WebDriver base URL pointed at the Superset backend for shared dev and non-dev Docker stacks; use the nginx endpoint only as a documented dev-screenshot override because nginx is unavailable in the non-dev stack. **Applied to:** - `docker/pythonpath_dev/superset_config.py` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
