codeant-ai-for-open-source[bot] commented on code in PR #42495: URL: https://github.com/apache/superset/pull/42495#discussion_r3694208279
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -277,7 +277,7 @@ WEBDRIVER_OPTION_ARGS = [ ] # This is for internal use, you can keep http -WEBDRIVER_BASEURL = "http://superset:8088"; # When running using docker compose use "http://superset_app:8088' +WEBDRIVER_BASEURL = "http://superset:8088"; # This is also the default for Docker Compose, where the app service is named "superset" Review Comment: **Suggestion:** This copy-paste configuration does not preserve `SUPERSET_APP_ROOT`. When the Compose deployment uses a prefix such as `/analytics`, setting `WEBDRIVER_BASEURL` to this unprefixed value causes cache warm-up to concatenate dashboard paths into `http://superset:8088/dashboard/...`, while the application only serves them under `/analytics/dashboard/...`. Document an app-root-aware value or state that this example is only for root deployments. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ❌ Dashboard cache warm-up requests receive 404 responses. - ⚠️ Subdirectory deployments require manual configuration correction. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=747e221a484642c89dcd2d6bad2abec2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=747e221a484642c89dcd2d6bad2abec2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/alerts-reports.mdx **Line:** 280:280 **Comment:** *Api Mismatch: This copy-paste configuration does not preserve `SUPERSET_APP_ROOT`. When the Compose deployment uses a prefix such as `/analytics`, setting `WEBDRIVER_BASEURL` to this unprefixed value causes cache warm-up to concatenate dashboard paths into `http://superset:8088/dashboard/...`, while the application only serves them under `/analytics/dashboard/...`. Document an app-root-aware value or state that this example is only for root deployments. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42495&comment_hash=d4aa06b052892b81ab028a687edb2c209b0b173cf1672e1b0fc95bf9b9bbc95f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42495&comment_hash=d4aa06b052892b81ab028a687edb2c209b0b173cf1672e1b0fc95bf9b9bbc95f&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
