bxsx commented on code in PR #42495: URL: https://github.com/apache/superset/pull/42495#discussion_r3694230321
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -277,7 +277,7 @@ WEBDRIVER_OPTION_ARGS = [ ] # This is for internal use, you can keep http -WEBDRIVER_BASEURL = "http://superset:8088"; # When running using docker compose use "http://superset_app:8088' +WEBDRIVER_BASEURL = "http://superset:8088"; # This is also the default for Docker Compose, where the app service is named "superset" Review Comment: The report/screenshot machinery this page documents doesn't read the base path at all — joined paths are root-relative, `urljoin` drops the base path, and the app-root prefix is applied on the path side from `APPLICATION_ROOT` (see the resolved thread above on this same line for details). Cache warm-up is the one consumer that concatenates paths onto this value, but it isn't the subject of this page — and `SUPERSET_APP_ROOT` is a Docker-Compose-specific variable, while this example is deployment-agnostic; running under a path prefix has its own section in `configuring-superset.mdx`. Apart from the hostname swap, this example predates the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
