bxsx commented on code in PR #42495: URL: https://github.com/apache/superset/pull/42495#discussion_r3694197202
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -402,9 +402,9 @@ Possible fixes: The worker may be unable to reach the report. It will use the value of `WEBDRIVER_BASEURL` to browse to the report. If that route is invalid, or presents an authentication challenge that the worker can't pass, the report screenshot will fail. -Check this by attempting to `curl` the URL of a report that you see in the error logs of your worker. For instance, from the worker environment, run `curl http://superset_app:8088/superset/dashboard/1/`. You may get different responses depending on whether the dashboard exists - for example, you may need to change the `1` in that URL. If there's a URL in your logs from a failed report screenshot, that's a good place to start. The goal is to determine a valid value for `WEBDRIVER_BASEURL` and determine if an issue like HTTPS or authentication is redirecting your worker. +Check this by attempting to `curl` the URL of a report that you see in the error logs of your worker. For instance, from the worker environment, run `curl http://superset:8088/superset/dashboard/1/`. You may get different responses depending on whether the dashboard exists - for example, you may need to change the `1` in that URL. If there's a URL in your logs from a failed report screenshot, that's a good place to start. The goal is to determine a valid value for `WEBDRIVER_BASEURL` and determine if an issue like HTTPS or authentication is redirecting your worker. Review Comment: Confirmed — with `Superset.route_base = ""` the canonical route is `/dashboard/<id>/` (`superset/views/core.py`), and `LegacyPrefixRedirectMiddleware` 308-redirects the legacy `/superset/dashboard/1/` form (and is slated for removal at 5.0.0 EOL, after which it will 404). A bare `curl` against the legacy path therefore shows a redirect that this very section tells readers to treat as an HTTPS/auth symptom. It's also not what the worker actually requests: report execution builds URLs via `url_for("Superset.dashboard", ...)`, which yields the canonical path. Updated the curl example (and the webhook payload sample earlier in the doc, which carried the same legacy path) to `/dashboard/1/` in https://github.com/apache/superset/pull/42495/commits/ea03fa0b571db040c10a06797d87c9da72663ff0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
