bito-code-review[bot] commented on code in PR #41492: URL: https://github.com/apache/superset/pull/41492#discussion_r3737242406
########## tests/unit_tests/db_engine_specs/test_sybase.py: ########## @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +def test_identifier_quote_uses_square_brackets() -> None: + """SAP ASE's `quoted_identifier` option defaults to OFF, so double quotes + aren't safe for autocomplete-inserted identifiers. Square brackets work + unconditionally, so SybaseEngineSpec keeps the MssqlEngineSpec default.""" + from superset.db_engine_specs.sybase import SybaseEngineSpec Review Comment: <!-- Bito Reply --> The suggestion to move the import to the module level is a standard practice for maintaining clean, readable code and avoiding potential issues, even if circular dependencies are not currently a concern. While local imports are sometimes used for specific performance or dependency reasons, following the established style guide is generally recommended for consistency across the codebase. You may choose to follow the suggestion to align with the project's style standards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
