bito-code-review[bot] commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3733478250
##########
superset-frontend/src/SqlLab/components/EditorWrapper/useKeywords.test.ts:
##########
@@ -210,6 +211,183 @@ test('quotes table identifiers that require quoting in
the inserted value', asyn
);
});
+test.each([
+ ['mysql', { start: '`', end: '`' }, '`COVID Vaccines`'],
+ ['mariadb', { start: '`', end: '`' }, '`COVID Vaccines`'],
+ ['mssql', { start: '[', end: ']' }, '[COVID Vaccines]'],
+ ['postgresql', { start: '"', end: '"' }, '"COVID Vaccines"'],
+ [
+ 'bigquery',
+ { start: '`', end: '`', escape_by_doubling: false },
+ '`COVID Vaccines`',
+ ],
+])(
+ 'quotes table identifiers using the engine-provided quote characters for %s',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Remove duplicated test setup code</b></div>
<div id="fix">
Consider refactoring duplicated test setup code in useKeywords.test.ts. Two
separate code blocks (lines 225-282 and 325-382) contain identical test
configuration. Extracting a common setup helper would improve maintainability.
</div>
</div>
<small><i>Code Review Run #dd0ec0</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
