rusackas commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3732857964
##########
superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx:
##########
@@ -57,6 +57,9 @@ export interface AceCompleterKeywordData {
meta: string;
docText?: string;
docHTML?: string;
+ // The label Ace displays in the autocomplete popup and passes back to
+ // `insertMatch`; may differ from `value`, the text actually inserted.
+ caption?: string;
Review Comment:
This duplication predates the PR, types.ts has mirrored index.tsx since
#31590. Consolidating them is a bigger refactor than a quote-chars fix should
take on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
