bito-code-review[bot] commented on code in PR #41492:
URL: https://github.com/apache/superset/pull/41492#discussion_r3733838895
##########
superset-frontend/src/SqlLab/components/EditorWrapper/useKeywords.test.ts:
##########
@@ -210,6 +211,183 @@ test('quotes table identifiers that require quoting in
the inserted value', asyn
);
});
+test.each([
+ ['mysql', { start: '`', end: '`' }, '`COVID Vaccines`'],
+ ['mariadb', { start: '`', end: '`' }, '`COVID Vaccines`'],
+ ['mssql', { start: '[', end: ']' }, '[COVID Vaccines]'],
+ ['postgresql', { start: '"', end: '"' }, '"COVID Vaccines"'],
+ [
+ 'bigquery',
+ { start: '`', end: '`', escape_by_doubling: false },
+ '`COVID Vaccines`',
+ ],
+])(
+ 'quotes table identifiers using the engine-provided quote characters for %s',
Review Comment:
<!-- Bito Reply -->
The suggestion to refactor the duplicated test setup code is valid and would
improve maintainability. The reviewer has already acknowledged the changes and
confirmed that the identifier quoting logic is now correctly handled within the
engine specs, with dialect-specific overrides implemented for MySQL/MariaDB and
MSSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
