bito-code-review[bot] commented on PR #42879:
URL: https://github.com/apache/superset/pull/42879#issuecomment-5257761999
<!-- Bito Reply -->
The flagged issue is correct. The `Select` component in
`GroupByFilterCard.tsx` already handles its own loading state via the
`loading={loading}` prop, which renders a spinner in the suffix. Adding a
separate `<Loading />` component below it creates redundant visual indicators.
To resolve this, you should remove the redundant `Loading` component block
entirely. Since the `Select` component already provides the necessary loading
feedback, the extra `div` is unnecessary.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx**
```
{loading && (
<div style={{ textAlign: 'center', marginTop: 8 }}>
<Loading position="inline" size="s" muted />
</div>
)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
