gabotorresruiz commented on code in PR #42879:
URL: https://github.com/apache/superset/pull/42879#discussion_r3784735187
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx:
##########
@@ -645,7 +645,7 @@ const GroupByFilterCard: FC<GroupByFilterCardProps> = ({
{loading && (
<div style={{ textAlign: 'center', marginTop: 8 }}>
- <Loading position="inline" />
+ <Loading position="inline" size="s" muted />
Review Comment:
The observation is accurate: the card also passes `loading` to the `Select`,
whose suffix icon becomes a small `Spin` while loading (`getSuffixIcon` in
`@superset-ui/core/components/Select/utils.tsx`), so there are two simultaneous
indicators. But that double indicator already exists on master; this PR only
mutes the heavier one, which is a strict improvement. Whether to drop the
standalone spinner entirely feels like a separate product decision, fine as a
follow-up. Not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
