codeant-ai-for-open-source[bot] commented on code in PR #42879:
URL: https://github.com/apache/superset/pull/42879#discussion_r3761009084
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx:
##########
@@ -645,7 +645,7 @@ const GroupByFilterCard: FC<GroupByFilterCardProps> = ({
{loading && (
<div style={{ textAlign: 'center', marginTop: 8 }}>
- <Loading position="inline" />
+ <Loading position="inline" size="s" muted />
Review Comment:
**Suggestion:** The `Select` above already receives `loading={loading}` and
renders its own loading spinner in the select suffix. Adding another `Loading`
component while the same flag is true produces two simultaneous loading
indicators for one column request, increasing visual noise and potentially
creating duplicate status announcements. Reuse one indicator or remove the
redundant loading state from the select. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Dynamic Group By loading shows two simultaneous indicators.
- ⚠️ Filter bar layout contains unnecessary loading affordance noise.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=88d8cadc432c4f5da2e958ff5e73f46a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=88d8cadc432c4f5da2e958ff5e73f46a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.tsx
**Line:** 648:648
**Comment:**
*Logic Error: The `Select` above already receives `loading={loading}`
and renders its own loading spinner in the select suffix. Adding another
`Loading` component while the same flag is true produces two simultaneous
loading indicators for one column request, increasing visual noise and
potentially creating duplicate status announcements. Reuse one indicator or
remove the redundant loading state from the select.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42879&comment_hash=513335c35726357682118e0d4f71ef0c48563ca7bedff64de04c05b02282d8af&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42879&comment_hash=513335c35726357682118e0d4f71ef0c48563ca7bedff64de04c05b02282d8af&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
