sadpandajoe commented on code in PR #42879:
URL: https://github.com/apache/superset/pull/42879#discussion_r3801433560
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.test.tsx:
##########
@@ -39,3 +51,27 @@ test('preserves source order when sortAscending is unset',
() => {
expect(compare(apple, banana)).toBe(0);
expect(compare(banana, apple)).toBe(0);
});
+
+const groupByCustomization = {
+ id: 'groupby-1',
+ name: 'Group By',
+ filterType: 'filter_groupby',
+ type: ChartCustomizationType.ChartCustomization,
+ targets: [{ datasetId: 1 }],
+ scope: { rootPath: [], excluded: [] },
+ controlValues: {},
+ defaultDataMask: {},
+} as unknown as ChartCustomization;
Review Comment:
Fixed in 6f4066b17d — replaced the `as unknown as ChartCustomization`
double-cast with a direct `: ChartCustomization` type annotation on the same
object literal, exactly as suggested. Verified `tsc --noEmit` is clean on this
file and the test still passes (4/4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
