msyavuz commented on PR #43330: URL: https://github.com/apache/superset/pull/43330#issuecomment-5342154054
> What if the same query worked correctly before, but when we rerun it, the database happens to go down at that moment? Would we then have to wait for the DB to be fixed before saving the query? > > I don't think it's a good idea for us to take responsibility for actions that are ultimately under the user's control. Save query is untouched: > Save query is unaffected; only dataset creation requires a successful run. Or are you saying we shouldn't block not working datasets from being created. If that is the point i can reframe the condition as `no columns available` instead of `last query failed` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
