varfigstar commented on PR #43330:
URL: https://github.com/apache/superset/pull/43330#issuecomment-5344104706
> Save query is untouched:
Yeah, I meant saving dataset
> Or are you saying we shouldn't block not working datasets from being
created. If that is the point i can reframe the condition as `no columns
available` instead of `last query failed`
I think we shouldn't block saving dataset at all. Even if there is query
error.
For example, I'm analyst and I made query in SQLab that fetched a lot of
data. Superset retrieved data, but DB went down in next second after this.
Analyst want to save dataset with this query but have no ability to do this
even if the SQL expression is correct, 'cause of crashed DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
