msyavuz commented on code in PR #43330:
URL: https://github.com/apache/superset/pull/43330#discussion_r3812967828
##########
superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx:
##########
@@ -43,8 +45,13 @@ const SaveDatasetActionButton = ({
color="default"
variant="text"
onClick={() => onSaveAsExplore?.()}
+ disabled={!canSaveDataset}
Review Comment:
Yes, allows_virtual_table_explore is a permanent database capability rather
than a transient state, so a always-disabled button would be noise on those
databases. The hide-vs-disable behavior there is pre-existing and untouched by
this PR; happy to revisit separately if we want capability gaps surfaced in the
UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
