geido commented on PR #43330: URL: https://github.com/apache/superset/pull/43330#issuecomment-5358347740
> > Save query is untouched: > > Yeah, I meant saving dataset > > > Or are you saying we shouldn't block not working datasets from being created. If that is the point i can reframe the condition as `no columns available` instead of `last query failed` > > I think we shouldn't block saving dataset at all. Even if there is query error. > > For example, I'm analyst and I made query in SQLab that fetched a lot of data. Superset retrieved data, but DB went down in next second after this. Analyst want to save dataset with this query but have no ability to do this even if the SQL expression is correct, 'cause of crashed DB. I think it's important to ensure that Superset can run on a healthy database, otherwise the error affects all assets which are based on top of it. I think it is perfectly fine to stop the creation if there is a temporary db error, just retry until the db is up again. If the db is flaky then you might not want to have that to power your data viz. I would say as long as we capture real errors, then we should block the creation. If the error is missing data then, we should still let it succeed. Is that how this is intended to work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
