villebro commented on code in PR #43337:
URL: https://github.com/apache/superset/pull/43337#discussion_r3814940166
##########
superset/models/helpers.py:
##########
@@ -2214,6 +2214,7 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
# Update result with processed data
result.df = df
+ result.sql_rowcount = len(df.index)
Review Comment:
Is `sql_rowcount` accurate here? It feels like `sql_rowcount` would be the
row count of the raw SQL result set from the initial query, and `rowcount`
would be the final post-processed rowcount which may be different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
