madhushreeag commented on code in PR #43337:
URL: https://github.com/apache/superset/pull/43337#discussion_r3815270777
##########
superset/models/helpers.py:
##########
@@ -2214,6 +2214,7 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
# Update result with processed data
result.df = df
+ result.sql_rowcount = len(df.index)
Review Comment:
removed this bit for this PR, this needs a discussion on what do we want to
display on top of the charts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
