madhushreeag commented on code in PR #43337:
URL: https://github.com/apache/superset/pull/43337#discussion_r3815500026


##########
superset/charts/schemas.py:
##########
@@ -972,21 +980,33 @@ class ChartDataGeodeticParseOptionsSchema(
 
 
 class ChartDataPostProcessingOperationSchema(Schema):
+    _builtin_ops = [
+        name
+        for name, value in inspect.getmembers(pandas_postprocessing, 
inspect.isfunction)
+    ]
+

Review Comment:
   __all__ is the explicit public API. Fix the schema to use it instead of 
inspect.getmembers:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to