bito-code-review[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5375456694
<!-- Bito Reply -->
The flagged issue is correct. The current implementation uses a hardcoded
"days" string, which results in grammatically incorrect output when the
retention period is one day. To resolve this, you should use the `nplurals`
support provided by the `t()` translation function (often via `tn()`) to handle
singular and plural forms correctly.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset-frontend/src/utils/softDeleteCopy.ts**
```
return plural
? tn(
'These %(type)s will be moved to Recently Archived in the
Settings menu. You can recover them there within %(days)d day.',
'These %(type)s will be moved to Recently Archived in the
Settings menu. You can recover them there within %(days)d days.',
days,
{ type: typeLabel, days },
)
: tn(
'This %(type)s will be moved to Recently Archived in the
Settings menu. You can recover it there within %(days)d day.',
'This %(type)s will be moved to Recently Archived in the
Settings menu. You can recover it there within %(days)d days.',
days,
{ type: typeLabel, days },
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
