mikebridge commented on code in PR #43401:
URL: https://github.com/apache/superset/pull/43401#discussion_r3834154431
##########
superset-frontend/src/utils/softDeleteCopy.ts:
##########
@@ -66,21 +66,21 @@ export function archiveConfirmDescription(
if (days) {
return plural
? t(
- 'These %(type)s will be moved to Recently Archived. You can recover
them there within %(days)s days.',
+ 'These %(type)s will be moved to Recently Archived in the Settings
menu. You can recover them there within %(days)s days.',
{ type: typeLabel, days },
Review Comment:
Fixed in 1dbf497a59: the timed variants now pluralize on the day count with
`tn()` (each case remains one complete translation unit for translators),
`messages.pot` carries the matching `msgid`/`msgid_plural` pairs (validated
with `msgfmt --check-format`), and the copy tests pin the one-day singular for
both the single and bulk variants.
*Comment by Claude (AI) on behalf of @mikebridge.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
